Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(how-to-guides): add training docs for centerpoint #471

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kaancolak
Copy link
Contributor

@kaancolak kaancolak commented Oct 18, 2023

Description

Prepare documentation about training lidar CenterPoint model

Blocked by:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kaancolak kaancolak self-assigned this Oct 18, 2023
@kaancolak kaancolak force-pushed the add-centerpoint-training-documentation branch 2 times, most recently from c2f7b5b to 6715a2d Compare November 13, 2023 20:44
@kaancolak kaancolak changed the title docs(how-to-guides): init training doc docs(how-to-guides): add training docs for centerpoint Nov 13, 2023
@kaancolak
Copy link
Contributor Author

kaancolak commented Nov 13, 2023

Hello @yukke42 -san, @miursh -san, @yukkysaito -san, @mitsudome-r -san

I prepared an overview section of lidar CenterPoint training under Autoware documentation and training steps under the "lidar_centerpoint" package.

Before we release the fork of the mmdetection3D and sample_dataset(Tier4 Format) under Autoware Foundation, please review the dataset and fork of the mmdetection3D repository. I am waiting for your feedback.

Fork of the mmdetection3D (dev-1.x-autoware branch):
Fork of the mmdetection 3D contains,

  • PyTorch to ONNX converter
  • Point Encoder optional use_voxel_center_z parameter
  • Tier4 dataset class
  • Custom metric calculator including NuScenes evaluation metrics (Original repository just support NuScenes dataset)

link : https://github.com/kaancolak/mmdetection3d/tree/dev-1.x-autoware

Sample Dataset(Tier4 Format)

  • Contains 600 lidar frames that are 3D labeled in 2 hz(6905 cars, 3951 pedestrians, 75 cyclists, 162 buses, and 326 trucks).

link: https://drive.google.com/drive/folders/15VeeXje1La0FwUyt1hU8pKXXfcCvRyiJ

@drwnz drwnz requested a review from miursh November 15, 2023 10:07
@mitsudome-r
Copy link
Member

@kaancolak FYI, I have created the fork of MMdetection under Autowarefoundation GitHub: https://github.com/autowarefoundation/mmdetection3d.
You should have access to create branch as well so feel free to port your work to the fork.

@miursh
Copy link
Contributor

miursh commented Nov 21, 2023

@kaancolak
I sincerely apologize for the delay in reviewing.
I have noted some comments and change requests regarding the dataset:

  1. A smaller file size for the T4 dataset is preferable, as the current size is leading to prolonged download times.
  2. The directory structure for each dataset should adhere to the guidelines outlined in this document. Specifically, there should be an 'annotation/data/input_bag' directory directly under 'T4_dataset_ID' (or 'scene_name').
  3. If the annotation frequency (Hz) is lower than that of the data, frames that were not annotated should not be included in sample.json. Additionally, for those frames, the is_key_frame in sample_data.json should be set to false. This might be due to our tools bug.
  4. It appears that the calibration, especially between CAM_BACK and base_link, is not well-aligned. Is this OK?

@kaancolak
Copy link
Contributor Author

Hi @miursh -san, thank you for your feedback. Following that, I plan to filter out non-annotated frames from the dataset. This will reduce the total size from 32 GB to approximately 6 GB and eliminate the need to deal with keyframes.

I will also inspect the calibration of the back camera. If there seems any issue, I can remove them from the dataset.

@kaancolak
Copy link
Contributor Author

Miura-san (@miursh),

I reloaded the dataset based on your feedback. Can you take a look and give feedback?

The total size decreased by around half of the previous version. (~13 GB)

The back camera is mounted on the rear glass of the vehicle and that part can be opened and closed as a car luggage. Somehow the calibration seems distorted, especially at a far distance. I removed it from the dataset.

Dataset link: https://drive.google.com/drive/folders/1qpts1HlOT3PdvrV_dRd1Q9syY2fhl8pO

@miursh
Copy link
Contributor

miursh commented Dec 1, 2023

@kaancolak I apologize for the delay in responding as I was taking a few days off.
The updated dataset looks good to me! Thank you for the change!

@kaancolak
Copy link
Contributor Author

Thank you so much @miursh -san. I will ask to Fatih upload the dataset to AWS.

kaancolak and others added 3 commits December 7, 2023 15:16
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
…odels.md

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@kaancolak kaancolak force-pushed the add-centerpoint-training-documentation branch from c401d46 to 6039d45 Compare December 7, 2023 06:21
@kaancolak kaancolak marked this pull request as ready for review December 7, 2023 06:21
@mitsudome-r mitsudome-r added the type:documentation Creating or refining documentation. label Dec 7, 2023
Copy link

stale bot commented Feb 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 6, 2024
@kminoda kminoda added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 19, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Feb 19, 2024
@Shin-kyoto Shin-kyoto requested review from Shin-kyoto and removed request for yukke42 February 19, 2024 12:04
kaancolak and others added 4 commits February 27, 2024 20:19
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
@xmfcx xmfcx requested a review from Shin-kyoto March 22, 2024 15:45
Copy link

stale bot commented May 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 26, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jun 4, 2024
@kaancolak
Copy link
Contributor Author

Hi @beginningfan, could you also review this document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants