Dev new recipe logic #926
Open
Dev new recipe logic #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opkg into dev_new_recipe_logic
gregneagle
reviewed
Jan 25, 2024
n8felton
reviewed
Jan 26, 2024
Comment on lines
+252
to
+257
| return True | ||
| # TODO: Implement this | ||
| # We need to determine if a recipe in the chain is an override and thus contains trust | ||
| # if it contains trust, we then go validate that the trust is correct | ||
| # if there are no overrides, this always returns True (but maybe we print out that we did nothing) | ||
| # for recipe in self.recipes: |
There was a problem hiding this comment.
Should this be implemented before this PR is merged?
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.