New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default dmg format and allow modern compression types #905
base: dev
Are you sure you want to change the base?
Conversation
Some further context as to why this would be useful. GitHub Enterprise prohibits git-lfs objects larger than 5gb and charges for ingress/egress usage. By utilizing better compression methods, companies can reduce their GitHub costs and also decrease the risk of autopkg binaries not being importable. |
Some interesting things, but I've found an even better compression when converting to a pkg vs a dmg.
This results in a 3.23gb pkg. |
I wanted to add that the automated tests for this PR passed on Ubuntu but failed on MacOS due to GitHub API limits exceeded which is not the fault of the PR itself, but is the fault of the fact that the github token currently isn't getting picked up by autopkg like it should at the moment. |
I think adding to the list of acceptable formats is obvious and should happen. I don't know if changing the default format for everyone makes as much obvious sense, but I also don't use AutoPkg for MacOS software currently, so it is not something I should have much opinion on. Would this mean the new defaults would cause a failure for anyone not running at least MacOS 13 Ventura if they do not change the new defaults? Or what versions of MacOS would it cut off? |
No. I'd love to do that but I opted for the 10.15 and higher version. If people are still running autopkg on insecure versions of macOS that no longer receive security updates I would question their commitment to their job for critical infrastructure like autopkg. |
I think this is a good idea. My vote for the new default compression format is UDLO, though maybe if I had more performance impact data I'd support UDMO. |
I would personally prefer UDMO as the default DMG format, but there is a significant performance penalty when creating the DMGs. I have only tested the performance on my fully managed macbook pro from 2019, but it was probably a 3x difference in the autopkg runs.
Example:
I'm wondering if there is more compression work that can be done here to get similar compression ratios to the original xip format that Apple utilizes.
from the manpage