Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Linux, the modification makes it possible to simulate the pressing of the "Windows" key which is Super when simulating the pressing of the key
key.Code.META
. Indeed, knowing that the key has been associated on Windows to the "Windows" key (winuser::VK_LWIN
) and on Mac OS to the "Apple" key (event::KeyCode::COMMAND
), it seems more coherent to point to the Super key on Linux (key code X11 ``XK_Super_L```).In any case, it would probably have been better to call this key "Super" and not "Meta" in the code, even if it means creating support for the "Meta" key separately (which is a very rare key, only existing on Sun computer keyboards according to Wikipedia).