add support for "vertical" orientation and "focus" centering methods #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See nerfstudio-project/nerfstudio#1543 - Also default to "vertical" which works better than "up" (nerfstudio-project/nerfstudio#1765) - Also rename train_split_percentage to train_split_fraction (nerfstudio-project/nerfstudio#1497)
|
@f-dy Awesome! Thanks for the PR. Will try it out later. |
ardaturkyasar
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample usage:
ns-train ... nerfstudio-data --center-method focus --orientation-method vertical"focus" centering method should not be the default, because it is to be used only for datasets where cameras are looking at a single object (there's some rejection logic in it, so it won't generate stupid results if some cameras are looking elsewhere). The default "poses" centering method generates a reasonable center in most cases (except aerial surveys maybe).