New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advice to display Version Catalog aliases #837
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you.
Since this is the first feature to directly support the version catalog concept, I think having a functional test is worth doing, even though it does indeed look quite safe. The test's purpose would be more to ensure there isn't a future regression. Let me know if I can provide any pointers here.
@autonomousapps I started to implement a functional test (mirroring the test harness I created under https://github.com/Chasson1992/DependencyAnalysisTest). I'm developing on a Windows 10 machine with IntelliJ Ultimate but when running the functionalTest task I'm getting a bunch of expections from:
I've been having a hard time figuring out the issue on this one. Any suggestions? I'll push what I have currently to my fork. |
Can you post more of the stacktrace? TBH I don't develop at all on Windows, so I'm not sure I'll be able to help, but at the least I'd need the full stacktrace. |
Fix #794
To allow advice to display the Version Catalog aliases we can iterate through each alias and add a mapping of the alias to the dependency in the DependencyHandler#map extension. Followed the recommendations from @daanschipper and @autonomousapps described in the issue.
I didn't add any functional tests, since it's fairly simple and safe, but I'm open to doing so.
A full working repository to demonstrate the issue is located here
buildHealth output before the changes:
buildHealth output after the changes: