Make sure all input files are using path sensitivity of relative to avoid cache misses in CI builds. #1107
+59
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void cache misses in CI builds.
jprinet
reviewed
Jan 22, 2024
| * jars really does matter here. Using [Classpath] is an error, as it looks only at content and | ||
| * not name or path, and we really do need to know the actual path to the artifact, even if its | ||
| * contents haven't changed. | ||
| */ | ||
| @PathSensitive(PathSensitivity.ABSOLUTE) | ||
| @PathSensitive(RELATIVE) |
There was a problem hiding this comment.
I would use a ClasspathNormalizer if @autonomousapps confirms that the requirement for absolute path is in the processing
autonomousapps
requested changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.