feat: sociable unit test functionality #275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-suites #275 +/- ##
=================================================
- Coverage 93.41% 92.61% -0.80%
=================================================
Files 19 24 +5
Lines 410 501 +91
Branches 81 91 +10
=================================================
+ Hits 383 464 +81
- Misses 16 27 +11
+ Partials 11 10 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
omermorad
force-pushed
the
next
branch
2 times, most recently
from
aa798a0
to
ee94156
Compare
omermorad
changed the title
|
@soryy708 up for review? |
| } | ||
|
|
||
| public static create<TClass = any>(targetClass: Type<TClass>): TestBedBuilder<TClass> { | ||
| public static create<TClass = any>(targetClass: Type<TClass>): SolitaryTestBedBuilder<TClass> { |
There was a problem hiding this comment.
lol. Yes it'a gonna be a whole new framework under the scope @suites.
| ); | ||
| } | ||
|
|
||
| public static sociable<TClass = any>(targetClass: Type<TClass>): SociableTestBedBuilder<TClass> { |
There was a problem hiding this comment.
I couldn't find any tests covering this new user-facing API?
I see tests that cover the insides, but nothing drives it as a user would?
There was a problem hiding this comment.
There is e2e that I need to apply as well, you are right
| ); | ||
|
|
||
| const testBed = await unitBuilder | ||
| .expose(UserApiService) |
There was a problem hiding this comment.
Because this is a public user-facing API, lets discuss the chosen terminology expose, to mark a dependency to not be faked.
What is the mental model Automock tries to give its users about what dependencies get replaced with test-doubles and what aren't?
In my mind for example, since Automock uses the terminology: automock, mock ... using, I'd expect this to be called dontMock or something like that.
|
Relates to: #230 |
No description provided.