Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scikit learn 1.2 #1611

Closed
wants to merge 25 commits into from
Closed

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Nov 15, 2022

This PR attempts to cleanly just update scikit-learn to 1.2 which necessitates updating to Python 3.8. This means we are locked out of Colab from any newer versions as Google Colab only support python 3.7

Will be a live PR, going through the changelogs for 1.0.2 and changelogs for 1.1.3


Supposedly relevant Changelog entries

  • API Change Deprecates datasets.load_boston in 1.0 and it will be removed in 1.2. Alternative code snippets to load similar datasets are provided. Please report to the docstring of the function for details. #20729 by Guillaume Lemaitre.

Write separate issue to update this. It will break a lot of our test fixtures.

Write separate issue to investigate this

Write seperate issue to investigate this

Seperate issue

Could be made to be iterative fit methods? Seperate issue


Next steps

  • Update test score fixtures
  • Update meta-learning most likely
  • Update docs, specifically that we deprecate Python 3.7 and using newer versions of Autosklearn will no longer work in Google Colab while they are fixed to Python 3.7

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1611 (7aa518e) into development (1abd1f9) will decrease coverage by 0.11%.
The diff coverage is 76.92%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1611      +/-   ##
===============================================
- Coverage        83.42%   83.32%   -0.11%     
===============================================
  Files              156      156              
  Lines            11927    12298     +371     
  Branches          1896     2033     +137     
===============================================
+ Hits              9950    10247     +297     
- Misses            1412     1453      +41     
- Partials           565      598      +33     

Impacted file tree graph

@ecederstrand
Copy link

I'm interested in this change. Is anything holding back this PR?

@github-actions github-actions bot added the Stale label May 30, 2023
@github-actions github-actions bot closed this Jun 6, 2023
@forzagreen
Copy link

Any updates on this ?

@AmirAlavi
Copy link

@eddiebergman can we help with this? Are the below two steps all that remains?

  • Update test score fixtures
  • Update meta-learning most likely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import classes from SMAC3 - "cannot import name <name> from smac"
5 participants