New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradebook UIUX #2123
Gradebook UIUX #2123
Conversation
app/assets/javascripts/SlickGrid/2.02/plugins/slick.autocolumnsize.js
Dismissed
Show dismissed
Hide dismissed
Warning Rate Limit Exceeded@KesterTan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 15 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates aim to enhance the Gradebook's user experience in SlickGrid by introducing auto column sizing and a customizable header menu, refining column management features, and improving styles. These changes streamline interactions, boost readability, and enhance functionality within the gradebook interface. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Could you add some images / videos of the UI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few comments:
- It might not be clear that double-clicking to resize columns is a feature unless somehow specified.
- Does the security report from CodeQL need to be addressed?
Added pictures in PR documentation and also added documentation about double click. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
docs/instructors.md (2)
Line range hint
159-165
: Consistent list item markers should be used. Replace dashes with asterisks for unordered list items.- - Provides an interface for manually entering problem scores (and problem feedback) for the most recent submission from each student. - - Provides an interface for viewing and annotating the submitted code. - - Displays the problem scores for the most recent submission for each student, summarizes any late penalties, and computes the total score. - - Provides a link to each student's handin history. + * Provides an interface for manually entering problem scores (and problem feedback) for the most recent submission from each student. + * Provides an interface for viewing and annotating the submitted code. + * Displays the problem scores for the most recent submission for each student, summarizes any late penalties, and computes the total score. + * Provides a link to each student's handin history.
Line range hint
183-183
: Ensure the file ends with a single newline character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
app/helpers/gradebook_helper.rb (3)
18-18
: Ensure consistency in column definitions.Consider adding
headerCssClass
for the "Course №" column to maintain consistency with other columns.
24-24
: Ensure consistency in column definitions.Consider adding
headerCssClass
for the "Grace Days" column to maintain consistency with other columns.
26-26
: Ensure consistency in column definitions.Consider adding
headerCssClass
for the "Penalty Late Days" column to maintain consistency with other columns.
Addresses #2034.
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting