Remove deprecated SVN code

[evanyeyeye]

Description

• Delete deprecated SVN-related code (AssessmentSVN, hasSVN, ModuleBase, Svn).
• Remove SVN-related database columns (has_svn, repository).

Motivation and Context

Closes #2067.

How Has This Been Tested?

• Verified that regular Autolab functions are working.
• Checked that schema.rb was modified appropriately.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve removing obsolete Subversion (SVN) code and related functionalities from the application, focusing on the removal of the has_svn attribute and SVN-related routes, actions, and database columns. This cleanup aligns with the shift towards GitHub integration for version control, eliminating unused and incomplete SVN implementation code from various parts of the application, including models, controllers, views, and database migrations.

Changes

File Path	Change Summary
app/controllers/.../assessments_controller.rb	Removed AssessmentSVN module inclusion and SVN-related auth actions; updated parameter permissions.
app/models/assessment.rb	Removed has_svn from serializable attributes.
app/views/assessments/_handin_form.html.erb	Changed conditional checks from @assessment.has_svn to assessment handin and quiz conditions.
config/routes.rb	Removed SVN-related routes (admin_svn, import_svn, set_repo).
db/migrate/.../remove_svn_data.rb	Migration to remove SVN-related columns (has_svn, repository) from tables.

Assessment against linked issues

Objective	Addressed	Explanation
Remove obsolete SVN code and related functionalities (e.g., svn.rb, routes, has_svn usage, columns) [#2067]	✅
Stop defining has_svn in assessment YAML files [#2067]	❓	The summary does not mention updates to YAML files directly, but the removal of has_svn from the code implies it's no longer needed. However, without explicit mention, it's unclear if YAML files were updated or checked.
Remove has_lang as it's similarly obsolete [#2067]	❌	There's no mention of removing or addressing has_lang, which was also listed as an objective.

The changes effectively address the main objective of removing obsolete SVN code, with a minor ambiguity regarding the direct handling of YAML file definitions and a missed objective concerning the has_lang attribute.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[KesterTan]

Looks pretty good, all the functions work as expected, could you also remove has_svn from the yml files in examples too

[KesterTan]

LGTM!