Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Submissions Button Functionalities #1903

Draft
wants to merge 8 commits into
base: feature/new-manage-submissions
Choose a base branch
from

Conversation

lykimchee
Copy link
Member

Resolves #1849

Description

Add functionality to majority of buttons (exceptions listed below) on the redesigned Manage Submissions interface. Exceptions are:

Also includes excused student marker (for #1855) and some commented code for the excused popup (for #1855, in-progress).

Includes a bug fix where only a certain number of table entries were shown— now the Manage Submissions table should show all submissions for an assignment.

Testing

Main

  • Create Submission, Download Final Submissions, and Manage Extensions should all work as intended
  • Missing Submissions should work but not in the redesigned manner

Inline

  • View Submission File (in row)
  • Delete Submission (in row)
  • [For Autograded] Regrade Submission (in row)

Selected

  • Select Submissions/All should activate the Regrade/Delete/Download Selected buttons (should originally be disabled)
  • [For Autograded] Regrade multiple submissions
  • Delete multiple submissions
  • Download multiple submissions

(Note: Original issue mentions changing wording of "Excuse Selected"/"Unexcuse Selected" in the button. This functionality was implemented in the first commit in this PR, but was removed upon further discussion in order to have a dropdown "Change Grade Type" button instead.)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@lykimchee lykimchee linked an issue May 15, 2023 that may be closed by this pull request
@michellexliu
Copy link
Contributor

image
I think all of the checkboxes should be shown as checked when the select all button is clicked

@michellexliu
Copy link
Contributor

image
am getting this error when i try to "change grade type"

@damianhxy damianhxy changed the base branch from feature/new-manage-submissions to master November 14, 2023 00:35
@damianhxy damianhxy changed the base branch from master to feature/new-manage-submissions November 14, 2023 00:35
@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Nov 14, 2023
@damianhxy damianhxy marked this pull request as draft December 28, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Manage Submissions] Buttons functionality
3 participants