New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Submissions Button Functionalities #1903
Draft
lykimchee
wants to merge
8
commits into
feature/new-manage-submissions
Choose a base branch
from
selected-buttons
base: feature/new-manage-submissions
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellexliu
requested changes
Sep 3, 2023
damianhxy
changed the base branch from
feature/new-manage-submissions
to
master
November 14, 2023 00:35
damianhxy
changed the base branch from
master
to
feature/new-manage-submissions
November 14, 2023 00:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1849
Description
Add functionality to majority of buttons (exceptions listed below) on the redesigned Manage Submissions interface. Exceptions are:
Also includes excused student marker (for #1855) and some commented code for the excused popup (for #1855, in-progress).
Includes a bug fix where only a certain number of table entries were shown— now the Manage Submissions table should show all submissions for an assignment.
Testing
Main
Inline
Selected
(Note: Original issue mentions changing wording of "Excuse Selected"/"Unexcuse Selected" in the button. This functionality was implemented in the first commit in this PR, but was removed upon further discussion in order to have a dropdown "Change Grade Type" button instead.)
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting