Improve Bazel support #303
Conversation
Vertexwahn
changed the title
There was a problem hiding this comment.
Hi @Vertexwahn , thanks for your contribution. Can we restrict this Pull Request to changes related to Bazel only? See other question on the need to change <> to "".
| @@ -10,7 +10,7 @@ using namespace Eigen; | |||
|
|
|||
| // autodiff includes | |||
| #define AUTODIFF_ENABLE_EIGEN_SUPPORT | |||
| #include <autodiff/reverse/var.hpp> | |||
| #include "autodiff/reverse/var.hpp" | |||
There was a problem hiding this comment.
Hi @Vertexwahn , why do we need to change from <> to ""?
There was a problem hiding this comment.
@allanleal I would use angle brackets only for system headers (e.g. <iostream>, <windows.h>) and double quotes for anything else (1, 2, 3) - this helps to get rid of copts = ["-I./"] which does not work when autodiff is used as a dependency
There was a problem hiding this comment.
@allanleal Is there a reason why this should or cannot be changed to double quotes? Let me know if this is definitely no option for you.
There was a problem hiding this comment.
I understand your point. Note that the use of <> instead of "" can be seen in prominent C++ projects (e.g. Boost). Before making this change, we would need to ensure that the integration of autodiff in projects that depend on the CMake find_package command will not be broken. Would you be able to check that?
MODULE.bazelfile