Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests + cleanup of real.hpp #278

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

PaulXiCao
Copy link
Contributor

@PaulXiCao PaulXiCao commented Dec 28, 2022

I worked on real.hpp. Nothing was fundamentally changed, more or less just formatting, refactoring, and extensive unit tests.

Important change: I removed constexpr from multiple overloads of <cmath> functions, e.g. abs, min, etc. See #275.

I went through all functions and tried to unify variable names, argument passing, etc.

@PaulXiCao PaulXiCao marked this pull request as ready for review December 28, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant