Fix some compiler warnings #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulXiCao
reviewed
Dec 22, 2022
| @@ -854,7 +854,7 @@ auto repr(const Real<N, T>& x) | |||
| { | |||
| std::stringstream ss; | |||
| ss << "autodiff.real("; | |||
| for(auto i = 0; i <= N; ++i) | |||
| for(decltype(N) i = 0; i <= N; ++i) | |||
There was a problem hiding this comment.
There are other "styles" possible here, e.g.
for(auto i = 0u; ...for(std::size_t i = 0; ...
Which is the preferred style for autodiff?
Comment on lines
125
to
+127
| assert(arg.size() == dir.size()); | ||
| for(auto i = 0; i < dir.size(); ++i) | ||
| size_t len = dir.size(); | ||
| for(decltype(len) i = 0; i < len; ++i) |
There was a problem hiding this comment.
One could remove len if we would use auto i = 0u or something similar.
|
Starting from cmake 3.24 there is also a target property for it: COMPILE_WARNING_AS_ERROR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects some compiler warnings:
ForEachWrtVarinforward/utils/gradient.hpp-Wsign-compare, stemming from a mismatch in types between the loop index and a some size variable in several places.After this change, I can compile cleanly with
-Wall -Werror.What are your thoughts on adding
-DCMAKE_CXX_FLAGS="-Wall -Werror"to the cmake configure step in CI? It makes it nicer to include a header a only library in other projects if it will compile without warnings, and this would help guarantee that.