Revert "Remove grad from variable exprs" #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts parts of commit 44e088c. The var.grad() api is more convenient than requiring to first bind a float and then reading it back. for instance, expr.propagate() and var.grad() can be used in unit tests. see also autodiff#177 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts parts of commit 44e088c.
The var.grad() api is more convenient than requiring to first bind a
float and then reading it back. for instance, expr.propagate() and
var.grad() can be used in unit tests. see also
#177 (comment)
I ran the unit test in autodiff/tests on linux, but i'm relatively new to pull requests in general and this project in particular. so please help to run everything needed :)