AX_PROG_CC_FOR_BUILD patches that fix BUILD_{EXE,OBJ}EXT (Autoconf 2.70) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoconf 2.70 introduced a change in AC_SUBST behavior that the variable name in AC_SUBST no longer gets macro expanded. This breaks the rename syntaxes of BUILD_EXEEXT and BUILD_OBJEXT in AX_PROG_CC_FOR_BUILD. Change to an alternative approach of assigning BUILD_EXEEXT and BUILD_OBJEXT manually. The values of EXEEXT and OBJEXT have to be fixed too at the end of the AX_PROG_CC_FOR_BUILD code.
Adjust the code of setting ac_cv_c_compiler_gnu to align with the code of ac_cv_exeext and ac_cv_objext. The solution is now permanent rather than just a workaround.
Fix regression where the ac_cv_prog_cc_c99 and ac_cv_prog_cc_c11 macros are not popped after the AX_PROG_CC_FOR_BUILD call. This can cause subsequents calls of AC_PROG_CC to use wrong cache variables to indicate C standard support. (Regression from serial 19 (16790f9). Note: It's unlikely for projects to call AC_PROG_CC again after AX_PROG_CC_FOR_BUILD, but such usage is valid.)
Improve compatibility with Autoconf 2.70 and later. Add support for these variables for indicating build compiler capabilities: * ac_cv_build_prog_cc_stdc (corresponding to ac_cv_prog_cc_stdc; Autoconf 2.70) * ac_build_prog_cc_stdc (corresponding to ac_prog_cc_stdc; Autoconf 2.70) * ac_cv_build_prog_cc_c23 (corresponding to ac_cv_prog_cc_c23; Autoconf 2.73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a mirror of patch #10452.
The BUILD_EXEEXT and BUILD_OBJEXT variables in AX_PROG_CC_FOR_BUILD are broken again in Autoconf 2.70 and later.
This patchset fixes compatibility problems found in Autoconf 2.70 and later.
BUILD_EXEEXTandBUILD_OBJEXTwork again.ac_cv_c_compiler_gnucode and make the solution permanent. The users should now be able to override theac_cv_build_c_compiler_gnucache variable.ac_cv_prog_cc_c99andac_cv_prog_cc_c11macrosare not popped after the
AX_PROG_CC_FOR_BUILDcall.ac_build_prog_cc_stdc(Autoconf 2.70) andac_cv_build_prog_cc_c23(Autoconf 2.73).