introduces support for optional resource type in ResourceFilter #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
former implementation of bulk-delete was designed to support deleting large amounts of relationships in a batched way. This commit replaces the implementation that relied on ReadRelationships with the new native DeleteRelationships optional-limit. The contract is kept mostly intact, except the interactive prompt is removed as it was considered bad UX. Instead, the same limits of 1000 before the user is prompted is retained, and instead zed will fail, indicating the user to bump the limit with the new --optional-limit flag, or to use --force. The --optional-limit flag sets the corresponding `DeleteRelationship` request field, and `--force` now sets the `OptionalAllowPartialDeletions` field. If set to true, all relationships will be deleted in batches defined by `--optional-limit`, which continues to default to 1000 elements. It also adds a progress bar to provide visual feedback to the user while deletion takes place.
This introduces support for optional resource type, recently introduced in SpiceDB 1.30.0. since the CLI contract has ambiguity, as a tradeoff, the contract will break by requiring clients to specify colon after the resource type, in order to disambiguate with _only specifying the relation_. The subject-type continues to not require colon as suffix. Tests were also added for missing permutations and the optional resource id prefix.
vroldanbet
force-pushed
the
update-bulk-delete
branch
from
4948920
to
1079bd6
Compare
vroldanbet
force-pushed
the
update-bulk-delete
branch
from
9f46e4e
to
c557965
Compare
An error occurred while trying to automatically change base from
update-bulk-delete
to
main
April 29, 2024 16:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for optional resource type, recently introduced in SpiceDB 1.30.0.
since the CLI contract has ambiguity, as a tradeoff, the contract will break by requiring clients to specify colon after the resource type, in order to disambiguate with only specifying the relation. The subject-type continues to not require colon as suffix.
Tests were also added for missing permutations and the optional resource id prefix.