Rebac annotations #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Add cypress workflow
samkim
force-pushed
the
rebac-annotations
branch
from
2dc4316
to
1f17f37
Compare
samkim
force-pushed
the
rebac-annotations
branch
from
1f17f37
to
9aeb6cf
Compare
jakedt
requested changes
Dec 6, 2022
| page-1-col-1: | ||
| what-is-rebac: | ||
| content: | | ||
| What is ReBAC? Relationship-based access control. The term was first coined in 2006 by Dr. Carrie E. Gates in her paper: [Access Control Requirements for Web 2.0 Security and Privacy](https://www.researchgate.net/publication/240787391_Access_Control_Requirements_for_Web_20_Security_and_Privacy) |
There was a problem hiding this comment.
I would take these front-matter annotations, combine them, and just put them all on the Introduction section header.
| page-2-col-1: | ||
| nested-groups: | ||
| content: | | ||
| Authorization services that infer a relationship graph from an existing database schema or map a graph to database tables run into issues with nested groups. Directly storing relation tuples is a key decision that supports nested groups. |
There was a problem hiding this comment.
Citation needed. A group database table with a nullable FK reference to the parent is a perfectly acceptable way to represent a graph of group memberships.
| Authorization services that infer a relationship graph from an existing database schema or map a graph to database tables run into issues with nested groups. Directly storing relation tuples is a key decision that supports nested groups. | ||
| scaling: | ||
| content: | | ||
| Not all applications that use Zanzibar may have Google’s traffic and not all Zanzibar implementations will be scaled to the size of Google’s internal implementation. However, the techniques used in Google’s implementation are still applicable to accomplish the same goals: Correctness, Flexibility, Low latency, HA, and Large scale. |
There was a problem hiding this comment.
I would lower case the list elements and spell out high availability
There was a problem hiding this comment.
Maybe change large scale to future-proof scale
| page-5-col-2: | ||
| zanzibar-annotations: | ||
| content: | | ||
| The following section dives into the internals of the system. See the [Introduction to Zanzibar](#annotations/intro) annotations for commentary. |
There was a problem hiding this comment.
This link didn't do anything for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.