Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: b2access loginpass #33

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TomasKulhanek
Copy link

B2ACCESS is an easy-to-use and secure Authentication and Authorization platform developed by EUDAT which delivers services for scientific, academia and research infrastructures cross border and cross discipline.

This PR adds oauth2 support for this service.

@lepture
Copy link
Member

lepture commented Jul 29, 2019

Thanks. I would prefer to pass the base_url in a function instead of using os.environ. Check https://github.com/authlib/loginpass/blob/master/loginpass/gitlab.py as an example.

… B2Access and B2AccessDev instances are provided
@TomasKulhanek
Copy link
Author

OK. Agree. I made update for default baseurl. This requires additional client code in case of non-default url, however, conforming the loginpass code style.

@lepture
Copy link
Member

lepture commented Jul 29, 2019

And also, can you provide a test case for it?

@TomasKulhanek
Copy link
Author

Added test case for b2access and registered in init.py file

@TomasKulhanek
Copy link
Author

The fork with this implementation of b2access is used in production for a month now without known problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants