New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(regulation): ip bans and unbanning #7230
base: master
Are you sure you want to change the base?
Conversation
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0e7abd8
to
adc5b7e
Compare
store: store, | ||
clock: clock, | ||
config: config, | ||
users: config.MaxRetries > 0 && (config.Mode == "user" || config.Mode == "both"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string both
has 2 occurrences, make it a constant (goconst)
internal/regulation/regulator.go
Outdated
} | ||
|
||
return BanTypeNone, "", nil, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Comment should end in a period (godot)
9bd7a1e
to
6dee5b2
Compare
This adds several new features to the regulation functionality including IP banning and the ability to unban users. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
6dee5b2
to
5b3ad5b
Compare
} | ||
} | ||
|
||
func (ctx *CmdCtx) StorageBansRevokeRunE(use string) func(cmd *cobra.Command, args []string) (err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
cyclomatic complexity 18 of func (*CmdCtx).StorageBansRevokeRunE
is high (> 15) (gocyclo)
This adds several new features to the regulation functionality including IP banning and the ability to unban users.