feat: listen on file descriptor #5973
Conversation
|
Thanks for choosing to contribute @oliverpool. We lint all PR's with golangci-lint and eslint, I may add a review to your PR with some suggestions. You are free to apply the changes if you're comfortable, alternatively you are welcome to ask a team member for advice. ArtifactsThese changes once approved by a team member will be published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| if a.url.Scheme == AddressSchemeFileDescriptor { | ||
| fd := os.NewFile(uintptr(a.port), strconv.Itoa(a.port)) | ||
| defer fd.Close() | ||
| return net.FileListener(fd) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
return statements should not be cuddled if block has more than two lines (wsl)
| @@ -23,6 +25,11 @@ | |||
|
|
|||
| return ln, err | |||
| } | |||
| if a.url.Scheme == AddressSchemeFileDescriptor { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
if statements should only be cuddled with assignments (wsl)
Closes #5971