Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reproducible #5232

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

build: reproducible #5232

wants to merge 7 commits into from

Conversation

james-d-elliott
Copy link
Member

@james-d-elliott james-d-elliott commented Apr 13, 2023

This (for the intent of eventually adding build reproducibility):

  • Adjusts the build date to be the commit date in RFC3339 format (same as OCI labels), using only the UTC timezone.
  • Allows injecting the build number by a CLI arg.
  • Allows printing the commands instead of running them.
  • Adjusts the OCI label to only use the UTC timezone.

@authelia
Copy link

authelia bot commented Apr 13, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:build-reproducible
  • docker pull ghcr.io/authelia/authelia:build-reproducible

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #5232 (08c6323) into master (998ffe5) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

❗ Current head 08c6323 differs from pull request most recent head 5afc1de. Consider uploading reports for the commit 5afc1de to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5232      +/-   ##
==========================================
- Coverage   68.19%   67.58%   -0.62%     
==========================================
  Files         280      278       -2     
  Lines       21865    21484     -381     
  Branches      438      438              
==========================================
- Hits        14910    14519     -391     
- Misses       6149     6168      +19     
+ Partials      806      797       -9     
Flag Coverage Δ
backend 68.50% <100.00%> (-0.65%) ⬇️
frontend 56.76% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/commands/build-info.go 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 5afc1de
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/6458936f31301100086c49f9
😎 Deploy Preview https://deploy-preview-5232--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott force-pushed the build-reproducible branch 7 times, most recently from c080c5e to 9462a0f Compare May 1, 2023 08:36
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant