Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: timing attack delayer #5011

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

james-d-elliott
Copy link
Member

No description provided.

@authelia
Copy link

authelia bot commented Mar 2, 2023

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:refactor-auth-delay
  • docker pull ghcr.io/authelia/authelia:refactor-auth-delay

internal/duo/duo.go Outdated Show resolved Hide resolved
internal/duo/types.go Outdated Show resolved Hide resolved
internal/middlewares/timing_attack_delay_test.go Outdated Show resolved Hide resolved
internal/server/handlers.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #5011 (e64bf26) into master (e07cfe1) will decrease coverage by 0.01%.
The diff coverage is 75.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5011      +/-   ##
==========================================
- Coverage   68.52%   68.51%   -0.01%     
==========================================
  Files         283      284       +1     
  Lines       20964    20999      +35     
  Branches      443      443              
==========================================
+ Hits        14365    14388      +23     
- Misses       5823     5839      +16     
+ Partials      776      772       -4     
Flag Coverage Δ
backend 68.97% <75.13%> (-0.01%) ⬇️
frontend 63.15% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/authentication/types.go 76.92% <ø> (ø)
internal/handlers/handler_reset_password_step1.go 65.71% <ø> (ø)
internal/random/mathematical.go 0.00% <ø> (ø)
internal/server/handlers.go 86.25% <18.18%> (-7.00%) ⬇️
internal/handlers/handler_firstfactor.go 55.81% <57.69%> (-3.18%) ⬇️
internal/middlewares/timing_attack_delay.go 94.64% <93.33%> (+0.76%) ⬆️
internal/authentication/delayed.go 100.00% <100.00%> (ø)
internal/commands/context.go 71.36% <100.00%> (+1.11%) ⬆️
internal/middlewares/identity_verification.go 79.28% <100.00%> (ø)
internal/random/cryptographical.go 44.15% <100.00%> (+1.48%) ⬆️
... and 8 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants