poc: feat: oidc bearer authz header #4322
Conversation
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
james-d-elliott
force-pushed
the
feat-oidc-bearer
branch
from
eceafbd
to
963304c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4322 +/- ##
===========================================
- Coverage 67.05% 40.38% -26.68%
===========================================
Files 263 264 +1
Lines 18271 18649 +378
Branches 431 431
===========================================
- Hits 12252 7531 -4721
- Misses 5292 10780 +5488
+ Partials 727 338 -389
Flags with carried forward coverage won't be shown. Click here to find out more.
|
james-d-elliott
force-pushed
the
feat-oidc-bearer
branch
from
963304c
to
cf31247
Compare
| ) | ||
|
|
||
| const ( | ||
| ContextKeySecretInternal = "urn:authelia:secret:internal" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
G101: Potential hardcoded credentials (gosec)
| accessForm.Set(oidc.FormCode, responder.GetParameters().Get(oidc.FormCode)) | ||
| accessForm.Set(oidc.FormCodeVerifier, verifier) | ||
| accessForm.Set(oidc.FormClientID, client.GetID()) | ||
| //accessForm.Set(oidc.FormClientSecret, config.Secret) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
commentFormatting: put a space between // and comment text (gocritic)
| "github.com/authelia/authelia/v4/internal/utils" | ||
| ) | ||
|
|
||
| func OpenIDConnectAutomaticAuthorizationBearer(ctx *middlewares.AutheliaCtx, client *oidc.Client, config *schema.OpenIDConnectAuthorizationBearerConfiguration) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
cyclomatic complexity 23 of func OpenIDConnectAutomaticAuthorizationBearer is high (> 15) (gocyclo)
| reqHTTPAccess.Header.Set("Content-Type", "application/x-www-form-urlencoded") | ||
|
|
||
| accessCtx := context.Background() | ||
| accessCtx = context.WithValue(accessCtx, oidc.ContextKeySecretInternal, true) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
james-d-elliott
force-pushed
the
feat-oidc-bearer
branch
from
6c3a215
to
61c09c4
Compare
No description provided.