Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC example to mimic CheckJWT functionality #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kingscott
Copy link

馃摑 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
    • N/A for this example
  • I have added documentation for all new/changed functionality (or N/A)

馃敡 Changes

  • Provided an example of how to use a new middleware, in a gRPC context, that replicates the CheckJWT functionality

馃摎 References

馃敩 Testing

  • This example only provides a documented example of how this middleware can be used - the code is not runnable
  • I opted to not provide tests for the middleware as they are quite lengthy and require a decent amount of boilerplate

@ewanharris
Copy link
Contributor

Thanks for the PR @kingscott! I think given the warnings from snyk around some of the dependencies being pulled in via go-kit this might prove difficult to get in.

Do you think it would be feasible to provide a barebones gRPC example rather than one built ontop of go-kit?

@kingscott
Copy link
Author

Hey @ewanharris - understandable. I'd need to dig in a bit more to how I'd do this; I've only really used go-kit for gRPC. Arguably, this PR could even be simplified to just show checking a JWT outside of a transport context? (Kind of like a helper method?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants