Use only code response type and drop implicit grant [SDK-2899]
#538
Conversation
Widcket
changed the title
code response type and drop implicit grantcode response type and drop implicit grant [SDK-2899]
| case missingResponseParam(String) | ||
| case invalidIdTokenNonce // TODO: Remove on the next major |
There was a problem hiding this comment.
This one stopped being used when the ID Token validation was implemented, adding errors of its own.
| entries["response_type"] = self.responseType.map { $0.label! }.joined(separator: " ") | ||
| entries["nonce"] = nonce | ||
| entries["organization"] = organization | ||
| entries["invitation"] = invitation |
There was a problem hiding this comment.
It's not really necessary to have if let organization = organization... to add optional values (value that may be nil). If it's nil, Swift won't add anything to the dictionary.
It's only necessary in the case of maxAge because it needs to be converted to String first, and for that, it must not be optional.
There was a problem hiding this comment.
| .start(onAuth) | ||
| } | ||
|
|
||
| @IBAction func startIDTokenGoogleOAuth2(_ sender: Any) { | ||
| Auth0.webAuth() | ||
| .logging(enabled: true) | ||
| .connection("google-oauth2") | ||
| .responseType([.idToken]) |
There was a problem hiding this comment.
Would it make sense to remove all these functions?
There was a problem hiding this comment.
What do you mean? That is the playground app
There was a problem hiding this comment.
We don't support IDToken, CodeIDToken etc. so why include them in the playground app?
There was a problem hiding this comment.
Yes, good catch. The playground app needs some work anyway, but I'll change the name of some of the methods and remove others.
There was a problem hiding this comment.
Done in 96d4927. Note that it still needs work.
Changes
The
responseType(_:)andusingImplicitGrant()methods from Web Auth were removed, along with theResponseTypeenum and theImplicitGrantstruct.Now the
coderesponse type is hardcoded and cannot be changed.Testing
The changes have been tested manually, by performing Web Auth login and logout in test apps, as follows:
Using Cocoapods
Using Carthage
macOS 11.6.1 CatalystCarthage does not support building XCFrameworks for macCatalystUsing SPM
Checklist