[nbapagerank] add static typechecking (mypy) and linting (black) #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5, #6
setting up incremental typechecking via
pyre
/watchman
seems like overkill for this project.went with
mypy
instead.added most of the type annotations in
nba_pagerank.py
; i don't thinknumpy
has typing readily available yet, so modeling explicitly as a 2D array of floats for now.type-checked and linted project.