Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Use vector graphics (fix Low resolution graphic) #45

Open
langestefan opened this issue Nov 11, 2023 · 5 comments
Open

Comments

@langestefan
Copy link

langestefan commented Nov 11, 2023

Thanks for this useful card. I noticed the graphic has a low rendering resolution:

image

Although it's still usable it makes the text blurry and hard to read both on mobile view and on desktop. Also the card elements themselves are not sharp. Not sure if this is easy to solve, as it's probably a result of the renderer you use.

@aukedejong
Copy link
Owner

I'm using a standard HTML canvas to render the windrose in.

This is a screencapture from Chrome on MacOs.

Screenshot 2023-11-28 at 21 30 46

I think it's sharp enough.

Is you browser scaled? Ctrl+0 or Cmd+0 should set it back to 100%?
Maybe OS scaling? Or maybe you PC and monitor resolution don't match. But then everything would be soft.
What browser and OS are you using?

@gilcu3
Copy link

gilcu3 commented Nov 29, 2023

Hi @aukedejong, I came looking for an issue on this after I noticed that the graphic is a bit blurry. This happens both in the android app, and in the web app using Firefox. In my case it is not that I cannot read the info, but that it looks blurry compared to other cards, which makes it noticeable. Would it be possible to use a higher resolution, or even better, vector graphics?

@langestefan
Copy link
Author

langestefan commented Nov 29, 2023

I'm using a standard HTML canvas to render the windrose in.

This is a screencapture from Chrome on MacOs.

Screenshot 2023-11-28 at 21 30 46 I think it's sharp enough.

Is you browser scaled? Ctrl+0 or Cmd+0 should set it back to 100%? Maybe OS scaling? Or maybe you PC and monitor resolution don't match. But then everything would be soft. What browser and OS are you using?

Your image is also blurry, look at the edges of the elements and the text. This is not how the other HA cards look. I am using chrome on linux, windows and I am using the companion app. It looks the same everywhere.

Example of the windrose card and another card on the same dashboard:

image

Windrose:

image

@aukedejong
Copy link
Owner

I see the difference.
I think we need to switch to vector graphics to fix this.

I'll will rename this issue and make it a feature request.

This means a complete rebuild of the render code.

@aukedejong aukedejong changed the title Low resolution graphic [Feature request] Use vector graphics (fix Low resolution graphic) Mar 9, 2024
@langestefan
Copy link
Author

Thanks for the input. I think that would be a really great upgrade, but I understand it's a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants