Use bool for predicates #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
reviewed
Nov 14, 2022
bettio
force-pushed
the
use-bools
branch
2 times, most recently
from
0a39ab3
to
5259fb4
Compare
fadushin
approved these changes
Nov 15, 2022
|
Also |
term.h wasn't using stdbool so predicate functions were returning int instead of bool. So change them to use instead bool. Signed-off-by: Davide Bettio <davide@uninstall.it>
Use bool instead of int for predicates. Signed-off-by: Davide Bettio <davide@uninstall.it>
Signed-off-by: Davide Bettio <davide@uninstall.it>
Avoid `if`s and use boolean expressions instead. Signed-off-by: Davide Bettio <davide@uninstall.it>
Signed-off-by: Davide Bettio <davide@uninstall.it>
Use bool for predicates instead of int. Signed-off-by: Davide Bettio <davide@uninstall.it>
Use bool for predicates instead of int. Signed-off-by: Davide Bettio <davide@uninstall.it>
Use bool for predicates instead of int. Signed-off-by: Davide Bettio <davide@uninstall.it>
Avoid `if`s and use boolean expressions instead. Signed-off-by: Davide Bettio <davide@uninstall.it>
|
This changes make sense from a theoretical point of view, from an empirical point of view they might slow down the generated binary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Davide Bettio davide@uninstall.it
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later