Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create first project page #22
base: develop
Are you sure you want to change the base?
docs: create first project page #22
Changes from 2 commits
726b6f5
a8052ab
8551a33
902a198
cfe5181
42c9a83
16fdd36
0d4b9ef
19c3f22
b34f327
168d9d6
7d5bccf
cde5d56
92b1194
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bence bu section gereksiz olmus ya. Belki seyden bahsedebiliriz. ITCSS ve BEM ile familiar degilseniz bu linklerden dokumantasyonlarina ulasabilirsiniz tarzi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burada bem yerine BEMIT ye yönlendirmeliyiz.
https://csswizardry.com/2015/08/bemit-taking-the-bem-naming-convention-a-step-further/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eger custom font kullaniyorsa
fonts
folder'ina nasil koyacak oraya koydugu sekli burada nasil kullanacak yazmakta fayda var bence. Iste ilk arguman adi, ikinci folder. ucunce dosya adinin extension'siz hali gibi.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burada
$g-font-family-sans-serif
body'nin font size'ını değiştirmiyor. Sadece sans-serif fontları tutan bir değişkenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burada
zeroed
yerine reset fiilini kullanmak daha iyi olacak gibi