remove-stale-msg-flag #2513
Open
remove-stale-msg-flag #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnevictoria
previously approved these changes
Nov 1, 2023
gxueatlassian
previously approved these changes
Nov 7, 2023
gxueatlassian
dismissed stale reviews from yvonnevictoria and themself
via
012190c
|
@joshkay10 Do we need to close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
removing the flag... and the code!!!!!!!!!!!!!!!!!!!!!!!!!!
This isn't as extreme as is appears, the flag has been returning false for months, it was useful to clean up the deployment queue when we had troubles, but now we are actively fixing things in the queue so we wont need it.
MOSTLY... i don't want code left in there thats going to be skipped indefinitely.