Display more information about deployment based on description #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the test. This is pure guessing. I was not able to run the test locally. |
benoittgt
force-pushed
the
more-infos-on-deploy-part2
branch
from
2345f90
to
4a042a6
Compare
As mentioned in [Github documentation](https://docs.github.com/en/rest/deployments/deployments#about-the-deployments-api): > Deployment statuses can also include an optional description and log_url, which are highly recommended because they make deployment statuses more useful. We want to avoid having duplicate information between "pipeline" and "deployments" and use the more rich informations provided on description. For people who use the classic Github Action to mark deployment as suggested by Jira. It's here: https://github.com/chrnorm/deployment-action/blob/880668c419e283adc6b1cc092d52eb5e558fec4d/action.yml#L24-L26 Related: - atlassian#1536 - atlassian#1732 - atlassian#1736
Instead of having basic information at initial deploy, we should prefer using Deployment Status description first. Example, the deployment failed. We could provide informations about why the deployment failed.
benoittgt
force-pushed
the
more-infos-on-deploy-part2
branch
from
4a042a6
to
f34d4b1
Compare
|
@benoittgt there are several checks failing. Could you please resolve this and we can work on getting this merged. |
|
Sorry that's an old work. I didn't have time yet to look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Github documentation:
We want to avoid having duplicate information between "pipeline" and "deployments" and use the more rich informations provided on description.
For people who use the classic Github Action to mark deployment as suggested by Jira. It's here:
https://github.com/chrnorm/deployment-action/blob/880668c419e283adc6b1cc092d52eb5e558fec4d/action.yml#L24-L26
Related: