Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQ-161: Fix IndexOutOfBoundsException when removing updated or created entities from context #3027

Merged
merged 1 commit into from May 17, 2024

Conversation

bichitra95
Copy link
Collaborator

@bichitra95 bichitra95 commented May 9, 2024

Change description

Removing entities from getCreatedEntities or getUpdatedEntities in PreProcessor throwing IndexOutOfBoundsException error. Fixing the loop with the copy array instead of the original array which is getting updated. Also, tested the changes in the datamesh.atlan.com tenant.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bichitra95 bichitra95 merged commit c6a4833 into master May 17, 2024
4 checks passed
@bichitra95 bichitra95 deleted the DQ-161 branch May 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants