Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Classification add/delete behaviour #2723

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

aarshi0301
Copy link

@aarshi0301 aarshi0301 commented Jan 4, 2024

Change description

JIRA :

https://atlanhq.atlassian.net/browse/PLT-367

Current behaviour :

Example :

If 3 tags are added to single entity

there use to be three CLASSIFICATION_ADDED events for that entity

If 3 tags are added to two entities

there use to be six CLASSIFICATION_ADDED events (3 events per entity)

Desired Behaviour:

Example :

If 3 tags are added to single entity

there will be one CLASSIFICATION_ADDEDevent for that entity

If 3 tags are added to two entities

there will be two CLASSIFICATION_ADDEDevent (1 event per entity)

Area of Impact :

  1. Audit events
  2. Kafka events
  3. AuditSearch API (consumed across multiple teams)

Proposed changes to embed desired behaviour :

  • Classification_added

    Current behaviour
    i. We have detail object that contains tag information.

    Proposed behaviour

    1. Representing Future classification_added event
      i. detail object will be empty.
      ii. add key classificationsDetails object to show current tags
      removed from entity.

    2. Representing Past data classification_added event
      i. detail object contains tag information.
      ii. classificationsDetails object will be empty

  • Classification_deleted event

    Current behaviour :
    i. We have detail object that contains tag typeName only.

    Proposed behaviour

    1. Representing Future classification_deleted event
      i. detail object will be empty.
      ii. add key classificationsDetails object to show current tags
      removed from entity.
    2. Representing Past data classification_added event
      i. detail object contains tag information.
      ii. classificationsDetails object will be empty.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@aarshi0301 aarshi0301 changed the title Feat/classification events Update Classification add/delete behaviour Jan 4, 2024
@aarshi0301 aarshi0301 marked this pull request as draft January 4, 2024 18:29
@aarshi0301 aarshi0301 added beta enhancement New feature or request labels Jan 4, 2024
@aarshi0301 aarshi0301 changed the base branch from beta to master January 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant