EVENT-49: replace argo-dataflow to numaflow
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
si3nloong
changed the title
argo-dataflow to numaflowargo-dataflow to numaflow
louisnow
requested changes
Nov 10, 2022
louisnow
reviewed
Nov 14, 2022
| @@ -68,7 +68,7 @@ class PackageInfo { | |||
| * @returns {string} | |||
| */ | |||
| getPackageLabel() { | |||
| return `${constants.ARGOPM_LIBRARY_NAME_LABEL}=${encode(this.name)}`; | |||
| return `${constants.ARGOPM_LIBRARY_NAME_LABEL}=${specialEncode(this.name)}`; | |||
There was a problem hiding this comment.
Why make this change? Is it safe/backwards compatible, etc?
There was a problem hiding this comment.
I do aware this might be a bug in the current argopm (0.8.5). You can refer to the following:
- When I run
argopm list -n default
- When I run
argopm info @atlan/mssql -n default, it throw error instead. As you can see the second screenshot, the URL passed over is/k8s/clusters/c-kzq84/apis/dataflow.argoproj.io/v1alpha1/namespaces/default/pipelines?pretty=&allowWatchBookmarks=&continue=&fieldSelector=&labelSelector=package.argoproj.io/name=-atlan-mssql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically replaces the pipeline template of
argo-dataflowwithnumaflowpipeline template.