deps retrieval compile time fix #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiraeeshi
reviewed
Jan 8, 2017
| lazy val mongoClient = new MongoClient(new ServerAddress(network.getServerAddress(), network.getPort())); | ||
| def getConn = { | ||
| val driver = new MongoDriver | ||
| val db = driver.connection(List(s"127.0.0.1:${network.getPort}"))("testdb") |
There was a problem hiding this comment.
Calling "apply" is deprecated, better use "database" method.
Hardcoding the name "testdb" is creating a restriction on database name. It seems like there's no way of getting database names in ReactiveMongo, I couldn't find any API through brief googling. Maybe we should use MongoClient here.
There was a problem hiding this comment.
ReactiveMongo gives an opportunity to run a custom command, so there is a way to get a list of all databases. I've made a pull request with an implementation of such a command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error on some missing dependency have been fixed and tested using travis.