-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dockerfile, Cypress, code generation, CodeMirror #1094
base: master
Are you sure you want to change the base?
feat: add Dockerfile, Cypress, code generation, CodeMirror #1094
Conversation
|
❌ Deploy Preview for modest-rosalind-098b67 failed.
|
❌ Deploy Preview for asyncapi-studio-design-system failed.
|
❌ Deploy Preview for studio-next failed.
|
@Amzani @KhudaDad414 |
I started with the addition of @Amzani
|
Not for the existing studio, we only have one for the new improvements that will be integrated once we finish the NextJS migration: https://www.figma.com/proto/bPMB3lkMTOOMuKk0oGLuNm/Studio?type=design&node-id=96-2392&scaling=contain&page-id=0%3A1&starting-point-node-id=2%3A2
I vote for
The goal is regression test, so I would suggest full flow (e2e), we can encourage components testing for new feature we add to the project. @KhudaDad414 WDY? |
I would remove CodeMirror Integration from the scope of this issue for now, until we merge everything. |
880b47e
to
5d9397e
Compare
I'm working on code generation for
Code, responsible for this is It needs to be checked on the server what version of |
@aeworxet we should remove the dependency with https://github.com/asyncapi/server-api in the NextJS version of studio as this repository might be deprecated soon. So the idea is to directly use the generator library. Not all of them supports V3, AFAIK the following supports V3
If < V3 all the generators should work as expected. |
@Amzani would you mind linking to where that decission has been made? Just to be in sync with asyncapi/server-api#576 where the idea, afaik, was to keep a server but the code living in CLI repo. |
e683688
to
cf031ba
Compare
@smoya I was assuming that if only Studio uses this API there is no need to maintain it anymore thus deprecating the |
@KhudaDad414 suggests the opposite, to stick with Should I invest time into rewriting the logic for SSR, or should I just bugfix the current approach? (#1094 (comment) is still relevant then) |
@aeworxet IMHO it makes sense to bug fix the current code base. By that I mean sticking to the server-api approach. As Fran said in the original issue, migration is already hard enough, trying to implement new features at the same time would quadruple the complexity. |
@KhudaDad414 |
@aeworxet Since you get the error on the current Studio as well, I would consider resolving it to be out of scope for this Bounty Issue. We can have another issue and discuss it over there. |
I'm investigating options for deployment of The most runtime-dynamic part of Studio currently is the generation of templates, and it can be done through a POST request to an API from a static website (it is made this way currently, in fact.) I'm not sure OG preview generation is a mandatory functionality for a containerized Studio, it can be left reserved for https://studio.asyncapi.com I have deployed to https://asyncapi-studio-studio-next.vercel.app a build of The whole 'export' build is nine (9) Mb, it has First Contentful Paint Should this version of Studio's build be used for a Docker container? |
We want to enable long term features like authentication for instance. generation of templates using API to POST should be something we could migrate IMO as we don't want to maintain an entire repository just for 1 single
How complex is having everything in Docker image? |
e1862f7
to
2319b09
Compare
It is supposed to be straightforward but I ran into an error on a command that executes fine on desktop, so I'm investigating it. |
I hoped to have for A request to the API works as a POC. I attempted to delete something unneeded, but it seems that everything in this Docker image is used for one process or another: Try image: cd ./apps/studio-next
docker build .
docker images # the freshly built Docker image is most probably the topmost one
docker run -p 3001:3001 [image_name]
http://localhost:3001 |
4dea6dc
to
8cc5df0
Compare
Quality Gate passedIssues Measures |
This PR finishes the migration of
Studio
to the React frameworkNext.js
.Cypress
testing tool:- GUI testing is invoked with
npm run cy:open
- Headless end-to-end testing for different browsers is invoked with
npm run cy:e2e:*
(refer to thecy:e2e:*
part ofpackage.json
for a list of available browsers (edge
is reserved for Windows machines))Monaco
code editor withCodeMirror
This PR is built on top of #1062, so it must be merged only AFTER.
Comparison with PR #1062
Resolves #661