Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add serialization alias for Pydantic #1859

Merged

Conversation

jonaslagoni
Copy link
Sponsor Member

Description

This PR adds serialization alias field tags for the Pydantic preset, so properties are accurately serialized and deserialized

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit ffc4179
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65e6e6ac36c50200088ac278

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni
Copy link
Sponsor Member Author

@dimitern another one.

@jonaslagoni
Copy link
Sponsor Member Author

This PR becomes even more important when we switch to the standardized styling format for properties as they are no longer 1:1 representation in most cases.

#1861

@dimitern
Copy link

dimitern commented Mar 5, 2024

Looks good to me

@jonaslagoni jonaslagoni merged commit 9495a40 into asyncapi:next Mar 6, 2024
24 checks passed
@jonaslagoni jonaslagoni deleted the add_serialization_alias_python branch March 6, 2024 09:49
@jonaslagoni
Copy link
Sponsor Member Author

Thanks folks 🙇

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants