Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: python pydantic follows v2 #1851

Merged
merged 1 commit into from Mar 4, 2024

Conversation

kennethaasan
Copy link
Collaborator

Description

The Pydantic preset should follow the v2 guidelines which is the latest version. This PR makes sure Modelina follows the Pydantic v2 guidelines: https://docs.pydantic.dev/2.6/migration/ by using description for the schema descriptions instead of alias.

Related Issue

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

@kennethaasan kennethaasan changed the title feat: python pydantic follows v2 feat!: python pydantic follows v2 Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit cf3b56b
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65e5beee593ea400080341de

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kennethaasan
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 2e2c0c2 into asyncapi:next Mar 4, 2024
28 checks passed
@kennethaasan kennethaasan deleted the python-pydantic branch March 4, 2024 12:45
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants