Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve kafka bindings #678

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

fix: improve kafka bindings #678

wants to merge 21 commits into from

Conversation

oviecodes
Copy link
Contributor

Description

This PR contains a fix for the Kafka adapter. The Kafka adapter should now start properly and run well.

Kindly have a look @Souvikns @KhudaDad414 , we also need to discuss about the setUpReplyMiddlewares in the src/index.js file.

Related issue(s)
Fixes #673

@oviecodes oviecodes changed the title Improve kafka bindings Fix: Improve kafka bindings Jan 8, 2024
@oviecodes oviecodes changed the title Fix: Improve kafka bindings fix: Improve kafka bindings Jan 8, 2024
@oviecodes oviecodes changed the title fix: Improve kafka bindings fix: improve kafka bindings Jan 8, 2024
KhudaDad414
KhudaDad414 reviewed Jan 12, 2024
View reviewed changes
src/adapters/kafka/index.ts Outdated
)
const userAndPasswordSecurityReq = securityRequirements.find(
(sec) => sec.type() === 'userPassword'
(sec) => sec.type === 'userPassword'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oviecodes what do you think about extracting these constants inside an enum? then reference it here as something like SECURITY_TYPE.USER_PASSWORD or SECURITY_TYPE.SCRAM_SHA_512 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright @KhudaDad414 .

@KhudaDad414
Copy link
Member

@oviecodes the branch has some conflicts.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 15, 2024 •
edited

Pull Request Test Coverage Report for Build 9096781342

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.714%
Totals Coverage Status
Change from base Build 8965267664: 0.0%
Covered Lines: 389
Relevant Lines: 486
💛 - Coveralls

@Souvikns
Copy link
Member

@oviecodes you have a lot of conflicts, do you need any help?

@oviecodes
Copy link
Contributor Author

oviecodes commented Mar 20, 2024 •
edited

I'll fix it @Souvikns , I've been a little occupied lately.

@KhudaDad414
Copy link
Member

@oviecodes This PR needs a little love, if you have the time of course.

@oviecodes
Copy link
Contributor Author

oviecodes commented May 7, 2024 •
edited

I'll fix this @KhudaDad414 ...

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas Awaiting requested review from fmvilas

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@KhudaDad414 KhudaDad414 Awaiting requested review from KhudaDad414 KhudaDad414 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oviecodes @KhudaDad414 @coveralls @Souvikns @asyncapi-bot