docs: adds auth concept to glee docs #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afzal442
requested review from
fmvilas,
Souvikns,
KhudaDad414 and
asyncapi-bot-eve
as code owners
KhudaDad414
reviewed
Nov 15, 2023
Comment on lines
112
to
114
| // done(true) | ||
| //done(false, 401, "Unauthorized") | ||
| // done(false) |
There was a problem hiding this comment.
I mean the done() function parameters should be explained as well. something like:
Parameters
- Authentication Result (
Boolean):truefor success,falsefor failure. - HTTP Status Code (
Integer): Code for authentication failure (e.g., 401 for Unauthorized). - Status Message (
String): Description of the authentication result (e.g., "Unauthorized").
|
@oviecodes can you take a look here? 🙇 |
|
Hey @KhudaDad414 it means that the Client |
KhudaDad414
previously approved these changes
Nov 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Souvikns
approved these changes
Nov 29, 2023
|
/rtm |
|
🎉 This PR is included in version 0.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces glee auth features.
Related issue(s)