Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add social network example #174

Merged
merged 7 commits into from
Dec 23, 2021
Merged

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Nov 9, 2021

Description

This example was created as part of the talk Fran Mendez did at QCon Plus 2021. I thought it would be cool to have it here too.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@boyney123
Copy link

Think the Example is great @fmvilas, I wonder if your README file if we could add a How it works section?

I understand how Glee works but I had to dig around the code to get an understanding of how it exactly works, for example which part of this application is Glee helping with? It might be useful to explain to people how glee was used in the example?

What do you think?

@fmvilas
Copy link
Member Author

fmvilas commented Dec 16, 2021

Think the Example is great @fmvilas, I wonder if your README file if we could add a How it works section?

I understand how Glee works but I had to dig around the code to get an understanding of how it exactly works, for example which part of this application is Glee helping with? It might be useful to explain to people how glee was used in the example?

What do you think?

Yeah, not in this PR but opened this follow up issue: #206. Thanks, Dave!

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 comments 🙂

Comment on lines +5 to +6
/.pnp
.pnp.js
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 First I thought it said php, and I was like 🤨

examples/social-network/notifications-service/package.json Outdated Show resolved Hide resolved
examples/social-network/websocket-server/package.json Outdated Show resolved Hide resolved
fmvilas and others added 2 commits December 17, 2021 13:27
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member Author

fmvilas commented Dec 17, 2021

Changes applied 😄 I don't care about the description of these apps, they're just examples so I better remove them haha!

PS: Love the auto-review hack with suggestions so I don't have to check it out on my machine 😂

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmvilas
Copy link
Member Author

fmvilas commented Dec 23, 2021

/rtm

@asyncapi-bot asyncapi-bot merged commit f478ceb into master Dec 23, 2021
@asyncapi-bot asyncapi-bot deleted the add-social-network-example branch December 23, 2021 10:25
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants