Skip to content

Commit

Permalink
feat: first support of bindings for AVRO key (#77)
Browse files Browse the repository at this point in the history
* feat: support of AVRO bindings key

Close #67

* fixup: PR review, only handle kafka key on bindings

* fix linter errors

* fixup: magicmatatjahu PR suggestion

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>

Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
  • Loading branch information
M3lkior and magicmatatjahu committed Sep 17, 2021
1 parent c8c9ce5 commit be78b76
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 0 deletions.
14 changes: 14 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ module.exports.parse = async ({ message, defaultSchemaFormat }) => {
message['x-parser-original-payload'] = message.payload;
message.payload = transformed;
delete message.schemaFormat;

// remove that function when https://github.com/asyncapi/spec/issues/622 will be introduced in AsyncAPI spec
async function handleKafkaProtocolKey() {
if (message.bindings && message.bindings.kafka) {
const key = message.bindings.kafka.key;
if (key) {
const bindingsTransformed = await avroToJsonSchema(key);
message['x-parser-original-bindings-kafka-key'] = key;
message.bindings.kafka.key = bindingsTransformed;
}
}
}

await handleKafkaProtocolKey();
};

module.exports.getMimeTypes = () => {
Expand Down
19 changes: 19 additions & 0 deletions tests/asyncapi-avro-1.9.0-bindings.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
asyncapi: 2.0.0
info:
title: My API
version: '1.0.0'
channels:
mychannel:
publish:
message:
schemaFormat: application/vnd.apache.avro;version=1.9.0
payload:
$ref: 'schemas/Person-1.9.0-namespace.avsc'
bindings:
kafka:
key:
$ref: 'schemas/Person-1.9.0-namespace.avsc'
mqtt:
x-test:
type: string

7 changes: 7 additions & 0 deletions tests/parse.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit be78b76

Please sign in to comment.