Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move astropy.samp to pyvo.astropy_samp #527

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MridulS
Copy link

@MridulS MridulS commented Feb 20, 2024

To fix #155 and another take on #239

@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2024

@astropy/coordinators -- how is Mridul not yet part of the org? Please resolve it, so we don't need to approve CI on his PRs.

@pllim
Copy link
Member

pllim commented Feb 20, 2024

Ooops. I have invited @MridulS to astropy-contributors. Hope this helps!

@pllim
Copy link
Member

pllim commented Feb 20, 2024

E astropy.samp.errors.SAMPProxyError: <SAMPProxyError 2: 'Client cli#2 not subscribed to MType table.load.votable'>

Not sure what is going on but @tomdonaldson and/or @astrofrog would be the best person to advice for this effort.

astropy already dropped Python 3.8 but hopefully should not matter here since we rarely touch astropy.samp.

@tomdonaldson tomdonaldson self-requested a review March 11, 2024 20:21
@ManonMarchand
Copy link
Member

It looks like the naming convention for the modules here is pyvo.group.standard or pyvo.standard which would give pyvo.app.samp or pyvo.samp. Which one do you all think is best ?

Also I cannot run the tests from this branch. It looks like they are disabled since this astropy/astropy@7c7e488 ?

@msdemlei
Copy link
Contributor

msdemlei commented Apr 15, 2024 via email

@pllim
Copy link
Member

pllim commented Apr 15, 2024

I cannot run the tests from this branch

Feel free to disable them in your branch here.

p.s. Though by now I think Mridul's contract is done and he has moved on, so maybe a pyvo maintainer should take this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move astropy.samp to pyvo
5 participants