Add default source nodes rendering #661
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
arojasb3
commented
Nov 9, 2023
| task_full_name = node.unique_id[len("source.") :] | ||
| task_id = f"{task_full_name}_source" | ||
| args["select"] = f"source:{node.unique_id[len('source.'):]}" | ||
| args["models"] = None |
There was a problem hiding this comment.
@tatiana I have a feeling that this lines can be written somewhere else.
My dbt testing showed that
dbt source freshness --models [any] fails, while using the --select works. I ended up manually setting as None the models argument.
Any thoughts?
arojasb3
commented
Nov 9, 2023
| if node.has_freshness is False: | ||
| return TaskMetadata( | ||
| id=task_id, | ||
| # arguments=args, |
There was a problem hiding this comment.
@tatiana Returning an EmptyOperator just seemed "grayish" in the dag UI. Looking at all the cool cosmos-related operators "DbtLocal..." "Dbt...", etc and having an EmptyOperator didn't seemed to go with the "cosmos pattern", Should we create a dummySourceOperator that inherits EmptyOperator just for the sake of having all Operators follow the same naming pattern?
arojasb3
commented
Nov 9, 2023
| @@ -742,3 +742,15 @@ def __init__(self, **kwargs: str) -> None: | |||
| raise DeprecationWarning( | |||
| "The DbtDepsOperator has been deprecated. " "Please use the `install_deps` flag in dbt_args instead." | |||
| ) | |||
|
|
|||
|
|
|||
| class DbtSourceLocalOperator(DbtLocalBaseOperator): | |||
tatiana
added
the
area:rendering
tatiana
added
the
status:awaiting-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm aiming to give a default behaviour to source nodes for checking their source freshness and their tests.
One of the main limitations I found while using the custom_callback functions on source nodes to check freshness is that those node were being created to 100% of sources but not all of them required freshness checks, this made workers waste compute time.
I'm adding a new variable into the DbtNode class called
has_freshnesswhich would be True for sources with freshness checks and False for the ones that not and any other resource type.All sources with the
has_freshness== False will be rendered as Empty Operators, to keep the dbt's behavior of showing sources as suggested in issue #630.Related Issue(s)
#630
Breaking Change?
Checklist