Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove distutils function and change packaging.version #37

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

ifurther
Copy link
Contributor

@ifurther ifurther commented Jan 1, 2023

distutils is removed in new version python

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (a890fa4) 88.43% compared to head (2a8c2bf) 88.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   88.43%   88.38%   -0.05%     
==========================================
  Files          11       11              
  Lines         536      534       -2     
==========================================
- Hits          474      472       -2     
  Misses         62       62              
Files Changed Coverage Δ
mpl_scatter_density/tests/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ifurther ifurther force-pushed the master branch 3 times, most recently from d5bf042 to 6feedab Compare January 4, 2023 13:15
@astrofrog
Copy link
Owner

Thanks for the PR! I have rebased this now that I've fixed the CI infrastructure.

@astrofrog
Copy link
Owner

We no longer need to use setup.py and we also don't need to check for the version in the tests anymore so actually simplifying this by removing the deprecated code.

@astrofrog astrofrog merged commit b33c541 into astrofrog:main Aug 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants