Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out majority of complexity in publish #743

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

golgor
Copy link

@golgor golgor commented Feb 22, 2024

The publish function only seems to work for publishing package on pypi.org or test.pypi.org and as I'm working primarily with a private company repository this was not ideal. Even though I used Rye for managing the whole project, I had to use Twine in a separate flow to publish the package.

After some initial discussions it turned out that Rye is using twine internally to publish packages, and there were thus no real reason why it was not working. After digging into it, the publish command basically wraps Twine, but it also adds a lot of fairly complicated checks and the parameters given to Twine was hard-coded to be a specific set of arguments adapted to publishing on pypi.org.

Commenting out the absolute majority of the additional command parsing made it work almost directly.

I just need to figure out what the rest of the commented code does and if we can remove it or if we have to adapt it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant