This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Fix for issue #179 #181
Open
Fix for issue #179 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2019
asticode
suggested changes
Apr 29, 2019
| @@ -269,7 +274,7 @@ func (a *Astilectron) execute() (err error) { | |||
| } else { | |||
| singleInstance = "false" | |||
| } | |||
| var cmd = exec.CommandContext(ctx, a.paths.AppExecutable(), append([]string{a.paths.AstilectronApplication(), a.listener.Addr().String(), singleInstance}, a.options.ElectronSwitches...)...) | |||
| var cmd = exec.CommandContext(ctx, a.paths.AppExecutable(), append([]string{a.paths.AstilectronApplication(), a.listener.Addr().String(), singleInstance, a.options.AppName}, a.options.ElectronSwitches...)...) | |||
There was a problem hiding this comment.
I'd rather have the full path provided here through the Paths structure:
- create a new attribute named
electronUserDatain thePathsstructure - compute its value in
newPathsusing the same logic you used in the JS PR. You should use otherPathsattributes such aselectronDirectorythat could be useful in your case to build the value. - provide it to Electron the same way you provided
a.options.AppName
| @@ -90,6 +90,10 @@ func New(o Options) (a *Astilectron, err error) { | |||
| return | |||
| } | |||
|
|
|||
| if o.AppName == "" { | |||
| o.AppName = "astilectron" | |||
There was a problem hiding this comment.
Could you use Astilectron instead of astilectron?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179
Partnering pull request can be found here: asticode/astilectron#20