New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug and add Feature to Group also for footprint #25
base: issue20
Are you sure you want to change the base?
Conversation
… Group componets for footprint size
lib/cfg.py
Outdated
if not csv_file: | ||
merge_file_item = os.path.join(path_file, bom_name) +'.xlsx' | ||
if not csv_file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non si poteva usare lo stesso if? c'è differenza a fare lo stesso controllo?
mergebom_class.py
Outdated
@@ -357,30 +358,47 @@ def statistics(self): | |||
def merge(self): | |||
self.group() | |||
self.count() | |||
d = {} | |||
listApp = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queste variabili vendono utilizzate fuori dal for? se no, perchè le dichiari qui e poi le usi solo all'interno dei cicli?
mergebom_class.py
Outdated
|
||
d = {} | ||
i = 0 | ||
e = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosa sono i e? volevi fare l'elenco delle vocali? e poi dove vendono usate?
mergebom_class.py
Outdated
d[item[self.TABLE_FOOTPRINT]] = [item] | ||
|
||
listApp.append(d.values()) | ||
for x in listApp[0]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queste due righe ce senso hanno? hai una lista di liste, o semplicemente una lista? non ha molto senso fare una lista di liste per un elemento solo e poi ciclare sul primo elemento della lista..
mergebom_class.py
Outdated
self.table[category], key=lambda x: x[ | ||
self.TABLE_COMMENT]) | ||
# Convert all ORDERED designator in a numeric format | ||
if category in ["R", "C", "L", "Y"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questo penso che non ne hai bisogno, perchè stai già ciclando sulle categorie..
Fix Bug of Parameters Controls in cfg_altiumWorkspace and add Feature Group componets for footprint size(with test)